[1.1] Fix dependency issue with Vite 5 #313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following dependency resolution issue for users of Vite 5 by allowing it to be a peer dependency in the latest version of this plugin.
Our understanding was that NPM would not attempt to install/upgrade this plugin to
v1.1
and instead continue to usev1.0
until the project's Vite dependency was bumped tov6
. However, it seems that NPM tries to install the latest versions purely based on the constraints inpackage.json
and then fails if they're incompatible instead of using the latest mutually compatible versions as Composer does.It would seem that with NPM, the only way to safely drop support for a peer dependency major version is with a major version release, so we've decided to reintroduce support for Vite 5, which matches official Vite plugins like
@vitejs/plugin-vue
.Fixes #311
Fixes #312